chore: updates to glibc vs musl#2902
Conversation
Signed-off-by: tdunlap607 <[email protected]>
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewhelmke
left a comment
matthewhelmke
left a comment
There was a problem hiding this comment.
Thank you for handling this update, @tdunlap607, based on the feedback from @catherinejones, who deserves a special shout out!
The deletions make sense and the changes are clear. So, LGTM and approved!
content/chainguard/chainguard-images/about/images-compiled-programs/glibc-vs-musl.md
Show resolved
Hide resolved
Signed-off-by: tdunlap607 <[email protected]>
matthewhelmke
left a comment
matthewhelmke
left a comment
There was a problem hiding this comment.
I like the new section and retaining the discussed link in it. Thanks!
jspeed-meyers
left a comment
jspeed-meyers
left a comment
There was a problem hiding this comment.
LGTM. Thank you, @tdunlap607, for the PR and @catherinejones for the feedback and expertise.
content/chainguard/chainguard-images/about/images-compiled-programs/glibc-vs-musl.md
Outdated
Show resolved
Hide resolved
catherinejones
left a comment
catherinejones
left a comment
There was a problem hiding this comment.
Thank you! I left a couple of small suggestions, but this looks good to me! :)
Signed-off-by: tdunlap607 <[email protected]>
|
Thank you again @catherinejones! The feedback is truly appreciated. Please feel free to reach out if you spot any other issues. |
|
Thank you, @tdunlap607, for the fixes and revisions. Thank you again, @catherinejones, for the thoughtful critique. Hopefully we gained a small bit of credibility back! 😆 😢 And please keep sending the feedback our way! I'm going to merge this PR. |
4 participants
After discussions with @catherinejones on the
glibc-vs-musl.mddocumentation, I removed several portions of the doc and focused more on speed/compatibility.The changes removed the buffer overflow, DNS issues (outdated), experimental warnings, and unsupported debug features. Old outdated references were pruned throughout the documentation as well.
Thank you @catherinejones for your thoughtful feedback. Please review at your convenience. Thank you!
cc @cartyc